Normalize mkdir() error codes

test/libc/calls/commandv_test.c

@@ -21,6 +21,7 @@
 #include "libc/calls/struct/dirent.h"
 #include "libc/calls/struct/stat.h"
 #include "libc/dce.h"
+#include "libc/fmt/fmt.h"
 #include "libc/log/check.h"
 #include "libc/mem/mem.h"
 #include "libc/runtime/gc.h"
@@ -33,14 +34,11 @@
 #include "libc/x/x.h"
 
 uint64_t i;
-char pathbuf[PATH_MAX];
-const char *testdir, *oldpath;
+char pathbuf[PATH_MAX], testdir[PATH_MAX], *oldpath;
 
 void SetUp(void) {
-  mkdir("o", 0755);
-  mkdir("o/tmp", 0755);
-  testdir = xasprintf("o/tmp/%s.%d", program_invocation_short_name, getpid());
-  mkdir(testdir, 0755);
+  sprintf(testdir, "o/tmp/%s.%d", program_invocation_short_name, getpid());
+  makedirs(testdir, 0755);
   CHECK_NE(-1, chdir(testdir));
   mkdir("bin", 0755);
   mkdir("home", 0755);

test/libc/calls/mkdir_test.c

@@ -0,0 +1,70 @@
+/*-*- mode:c;indent-tabs-mode:nil;c-basic-offset:2;tab-width:8;coding:utf-8 -*-│
+│vi: set net ft=c ts=2 sts=2 sw=2 fenc=utf-8                                :vi│
+╞══════════════════════════════════════════════════════════════════════════════╡
+│ Copyright 2021 Justine Alexandra Roberts Tunney                              │
+│                                                                              │
+│ Permission to use, copy, modify, and/or distribute this software for         │
+│ any purpose with or without fee is hereby granted, provided that the         │
+│ above copyright notice and this permission notice appear in all copies.      │
+│                                                                              │
+│ THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL                │
+│ WARRANTIES WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED                │
+│ WARRANTIES OF MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE             │
+│ AUTHOR BE LIABLE FOR ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL         │
+│ DAMAGES OR ANY DAMAGES WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR        │
+│ PROFITS, WHETHER IN AN ACTION OF CONTRACT, NEGLIGENCE OR OTHER               │
+│ TORTIOUS ACTION, ARISING OUT OF OR IN CONNECTION WITH THE USE OR             │
+│ PERFORMANCE OF THIS SOFTWARE.                                                │
+╚─────────────────────────────────────────────────────────────────────────────*/
+#include "libc/calls/calls.h"
+#include "libc/errno.h"
+#include "libc/fmt/fmt.h"
+#include "libc/log/check.h"
+#include "libc/runtime/runtime.h"
+#include "libc/testlib/testlib.h"
+#include "libc/x/x.h"
+
+char testdir[PATH_MAX];
+
+void SetUp(void) {
+  sprintf(testdir, "o/tmp/%s.%d", program_invocation_short_name, getpid());
+  makedirs(testdir, 0755);
+  CHECK_NE(-1, chdir(testdir));
+}
+
+void TearDown(void) {
+  CHECK_NE(-1, chdir("../../.."));
+  CHECK_NE(-1, rmrf(testdir));
+}
+
+TEST(mkdir, testNothingExists_ENOENT) {
+  EXPECT_EQ(-1, mkdir("yo/yo/yo", 0755));
+  EXPECT_EQ(ENOENT, errno);
+}
+
+TEST(mkdir, testDirectoryComponentIsFile_ENOTDIR) {
+  EXPECT_NE(-1, touch("yo", 0644));
+  EXPECT_EQ(-1, mkdir("yo/yo/yo", 0755));
+  EXPECT_EQ(ENOTDIR, errno);
+}
+
+TEST(mkdir, testPathIsFile_EEXIST) {
+  EXPECT_NE(-1, mkdir("yo", 0755));
+  EXPECT_NE(-1, mkdir("yo/yo", 0755));
+  EXPECT_NE(-1, touch("yo/yo/yo", 0644));
+  EXPECT_EQ(-1, mkdir("yo/yo/yo", 0755));
+  EXPECT_EQ(EEXIST, errno);
+}
+
+TEST(mkdir, testPathIsDirectory_EEXIST) {
+  EXPECT_NE(-1, mkdir("yo", 0755));
+  EXPECT_NE(-1, mkdir("yo/yo", 0755));
+  EXPECT_NE(-1, mkdir("yo/yo/yo", 0755));
+  EXPECT_EQ(-1, mkdir("yo/yo/yo", 0755));
+  EXPECT_EQ(EEXIST, errno);
+}
+
+TEST(makedirs, testEmptyString_ENOENT) {
+  EXPECT_EQ(-1, makedirs("", 0755));
+  EXPECT_EQ(ENOENT, errno);
+}

test/libc/fmt/dirname_test.c

@@ -30,4 +30,5 @@ TEST(dirname, test) {
   EXPECT_STREQ(".", dirname(gc(strdup("hello"))));
   EXPECT_STREQ(".", dirname(gc(strdup("."))));
   EXPECT_STREQ(".", dirname(gc(strdup(".."))));
+  EXPECT_STREQ("", dirname(gc(strdup(""))));
 }