Make redbean StoreAsset() work better

- Better UBSAN error messages
- POSIX Advisory Locks polyfills
- Move redbean manual to /.help.txt
- System call memory safety in ASAN mode
- Character classification now does UNICODE

test/libc/calls/writev_test.c

@@ -18,9 +18,12 @@
 ╚─────────────────────────────────────────────────────────────────────────────*/
 #include "libc/calls/calls.h"
 #include "libc/calls/struct/iovec.h"
+#include "libc/dce.h"
 #include "libc/errno.h"
 #include "libc/macros.internal.h"
+#include "libc/runtime/runtime.h"
 #include "libc/sock/sock.h"
+#include "libc/sysv/consts/auxv.h"
 #include "libc/sysv/consts/o.h"
 #include "libc/testlib/testlib.h"
 
@@ -59,6 +62,29 @@ TEST(writev, big_fullCompletion) {
   EXPECT_NE(-1, close(fd));
 }
 
+TEST(writev, asanError_efaults) {
+  if (!IsAsan()) return;
+  void *malloc_(size_t) asm("malloc");
+  void free_(void *) asm("free");
+  void *p;
+  int fd;
+  p = malloc_(32);
+  EXPECT_NE(-1, (fd = open("asan", O_RDWR | O_CREAT | O_TRUNC, 0644)));
+  EXPECT_EQ(32, write(fd, p, 32));
+  EXPECT_NE(-1, lseek(fd, 0, SEEK_SET));
+  EXPECT_EQ(32, read(fd, p, 32));
+  EXPECT_EQ(-1, write(fd, p, 33));
+  EXPECT_EQ(EFAULT, errno);
+  EXPECT_EQ(-1, write(fd, p, -1));
+  EXPECT_EQ(EFAULT, errno);
+  free_(p);
+  EXPECT_EQ(-1, write(fd, p, 32));
+  EXPECT_EQ(EFAULT, errno);
+  EXPECT_EQ(-1, read(fd, p, 32));
+  EXPECT_EQ(EFAULT, errno);
+  close(fd);
+}
+
 TEST(writev, empty_stillPerformsIoOperation) {
   int fd;
   struct iovec iov[] = {{"", 0}, {NULL, 0}};

test/libc/fmt/fmt_test.c

@@ -276,3 +276,8 @@ TEST(fmt, p) {
   EXPECT_STREQ("0xffff800000031337",
                gc(xasprintf("% 10p", 0xffff800000031337)));
 }
+
+/* TEST(fmt, funchar) { */
+/*   /\* TODO(jart): fix this *\/ */
+/*   ASSERT_STREQ("'\\200'", gc(xasprintf("%`'c", 0200))); */
+/* } */

test/libc/intrin/asan_test.c

@@ -0,0 +1,42 @@
+/*-*- mode:c;indent-tabs-mode:nil;c-basic-offset:2;tab-width:8;coding:utf-8 -*-│
+│vi: set net ft=c ts=2 sts=2 sw=2 fenc=utf-8                                :vi│
+╞══════════════════════════════════════════════════════════════════════════════╡
+│ Copyright 2021 Justine Alexandra Roberts Tunney                              │
+│                                                                              │
+│ Permission to use, copy, modify, and/or distribute this software for         │
+│ any purpose with or without fee is hereby granted, provided that the         │
+│ above copyright notice and this permission notice appear in all copies.      │
+│                                                                              │
+│ THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL                │
+│ WARRANTIES WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED                │
+│ WARRANTIES OF MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE             │
+│ AUTHOR BE LIABLE FOR ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL         │
+│ DAMAGES OR ANY DAMAGES WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR        │
+│ PROFITS, WHETHER IN AN ACTION OF CONTRACT, NEGLIGENCE OR OTHER               │
+│ TORTIOUS ACTION, ARISING OUT OF OR IN CONNECTION WITH THE USE OR             │
+│ PERFORMANCE OF THIS SOFTWARE.                                                │
+╚─────────────────────────────────────────────────────────────────────────────*/
+#include "libc/dce.h"
+#include "libc/intrin/asan.internal.h"
+#include "libc/mem/mem.h"
+#include "libc/testlib/testlib.h"
+
+TEST(asan, test) {
+  char *p;
+  if (!IsAsan()) return;
+  p = gc(malloc(3));
+  EXPECT_TRUE(__asan_is_valid(p, 3));
+  EXPECT_FALSE(__asan_is_valid(p, 4));
+  EXPECT_TRUE(__asan_is_valid(p + 1, 2));
+  EXPECT_FALSE(__asan_is_valid(p + 1, 3));
+  p = gc(malloc(8 + 3));
+  EXPECT_TRUE(__asan_is_valid(p, 8 + 3));
+  EXPECT_FALSE(__asan_is_valid(p, 8 + 4));
+  EXPECT_TRUE(__asan_is_valid(p + 1, 8 + 2));
+  EXPECT_FALSE(__asan_is_valid(p + 1, 8 + 3));
+  p = gc(malloc(64 + 3));
+  EXPECT_TRUE(__asan_is_valid(p, 64 + 3));
+  EXPECT_FALSE(__asan_is_valid(p, 64 + 4));
+  EXPECT_TRUE(__asan_is_valid(p + 1, 64 + 2));
+  EXPECT_FALSE(__asan_is_valid(p + 1, 64 + 3));
+}

test/libc/intrin/test.mk

@@ -26,6 +26,7 @@ TEST_LIBC_INTRIN_DIRECTDEPS =				\
 	LIBC_FMT					\
 	LIBC_INTRIN					\
 	LIBC_LOG					\
+	LIBC_MEM					\
 	LIBC_NEXGEN32E					\
 	LIBC_RAND					\
 	LIBC_RUNTIME					\

test/libc/str/regex_test.c

@@ -154,4 +154,17 @@ BENCH(regex, bench) {
   EZBENCH2("precompiled nosub match", donothing, D(&rx, m));
   free(m);
   regfree(&rx);
+  EXPECT_EQ(REG_OK, regcomp(&rx, "^[a-z]*$", REG_EXTENDED | REG_NOSUB));
+  m = calloc(rx.re_nsub + 1, sizeof(regmatch_t));
+  EZBENCH2("precompiled alpha", donothing,
+           regexec(&rx, "aaaaaaaaaaaaaaaaaaaaaaaaaaaaa", 0, 0, 0));
+  free(m);
+  regfree(&rx);
+  EXPECT_EQ(REG_OK,
+            regcomp(&rx, "^[a-z]*$", REG_EXTENDED | REG_NOSUB | REG_ICASE));
+  m = calloc(rx.re_nsub + 1, sizeof(regmatch_t));
+  EZBENCH2("precompiled alpha icase", donothing,
+           regexec(&rx, "aaaaaaaaaaaaaaaAAAAAAAAAAAAAA", 0, 0, 0));
+  free(m);
+  regfree(&rx);
 }